Skip to content

fix(cua-driver): match localized macOS Chrome consent dialogs - #3409

Draft
enderzcx wants to merge 1 commit into
trycua:mainfrom
enderzcx:codex/macos-localized-chrome-consent
Draft

fix(cua-driver): match localized macOS Chrome consent dialogs#3409
enderzcx wants to merge 1 commit into
trycua:mainfrom
enderzcx:codex/macos-localized-chrome-consent

Conversation

@enderzcx

@enderzcx enderzcx commented Aug 27, 2026

Copy link
Copy Markdown

Summary

  • Problem this solves: macOS existing-profile attachment recognizes Chrome's browser-owned remote-debugging consent sheet from English text, so a valid localized sheet can remain visible while browser_prepare fails with browser_wrong_target_refused.
  • What changed: keep the existing English semantic matcher, then use a language-independent structural fallback that requires one exact AXSheet, a heading bound to the sheet title, two explanatory text nodes, and exactly three pressable buttons forming one unambiguous AppKit dialog row. The outer standard action is selected as Allow and the adjacent standard action as Cancel, including mirrored RTL layouts. Ambiguous or incomplete sheets still fail closed.

The driver and public browser guidance now distinguish localized setup-page limitations from the native consent dialog, which no longer depends on button text on macOS.

Related work

Refs #2892

RFC: not required; this preserves the existing MCP, permission, and exact-window contracts and changes only the macOS platform matcher.

Compatibility and risk

  • User-visible, API/CLI/MCP, migration, permission, or platform impact: macOS Chrome/Edge consent dialogs can be accepted when their UI is localized. There is no API, CLI, MCP schema, permission-mode, or migration change. Localized controls on the internal setup page remain outside this change.
  • Risk and rollback: the structural fallback is constrained to the exact approved Chromium process and sheet. It requires a title/heading binding, two explanatory text nodes, three distinct in-sheet AXPress buttons, and a unique separated standard pair. Any geometry or cardinality ambiguity returns browser_wrong_target_refused. Rollback is the single commit in this PR.

Validation

  • Focused tests and checks:
    • cargo test -p platform-macos browser::consent_ui::tests --lib --locked (7 passed)
    • cargo test -p platform-macos --lib --locked (347 passed, 2 ignored environment tests)
    • cargo fmt --all -- --check
    • cargo clippy -p platform-macos --lib --locked --no-deps -- -D warnings with only pre-existing crate lint categories allowed (passed; the unfiltered command currently fails in unrelated existing modules)
    • Cua Driver documentation generator drift check (passed)
    • public docs hygiene check (passed)
    • git diff --check
  • Manual or platform evidence: reproduced with Chrome 148 on macOS using a Simplified Chinese consent sheet. The live AX structure exposed one bound sheet/heading, two explanatory text nodes, and the three-button AppKit layout represented by the regression fixture. No page content, profile paths, cookies, or screenshots are included.
  • Known gaps or CI still required: the release-signed macOS existing-profile E2E should run in the maintainer harness. Installing a locally signed bundle would change TCC identity, so this contribution does not claim a local release-bundle E2E result.

Contributor and release checks

  • The PR is focused and the description matches the final diff.
  • This change does not require an RFC, or the accepted RFC is linked above.
  • Tests, documentation, and platform evidence are included or the gap is explained.
  • The PR title is a Conventional Commit describing the production change.
  • External contributor authorship is preserved, or no external contribution is included.
  • If release-tracked files changed but this is intentionally non-releasing, the no-release label is applied. (Not applicable: this is a user-visible Cua Driver fix.)

This was referenced Sep 10, 2026
Merged
Open
Merged
injaneity added a commit that referenced this pull request Sep 10, 2026
@injaneity
chore(cua-driver): begin exact consent-label lifecycle regression
1522430 
Refs #3705. Reuse the existing public browser_prepare lifecycle test for native red before changing semantic matching. Related localization contributions #3409 and #3140 remain separate.
injaneity added a commit that referenced this pull request Sep 10, 2026
@injaneity
fix(cua-driver): normalize repeated macOS consent labels (#3706)
4c96f24 
* chore(cua-driver): begin exact consent-label lifecycle regression

Refs #3705. Reuse the existing public browser_prepare lifecycle test for native red before changing semantic matching. Related localization contributions #3409 and #3140 remain separate.

* fix(cua-driver): deduplicate repeated native consent labels

Normalize identical AX text fields once so an English Allow/Cancel title repeated in the description remains an exact semantic match. Distinct text still combines, and sheet ownership, action capability, uniqueness, and ambiguity checks remain unchanged. Refs #3705.
f-trycua
f-trycua requested changes Sep 13, 2026
View reviewed changes

@f-trycua f-trycua left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structural fallback is too broad for a consent action. Any sheet in the approved Chromium process with a title-matching heading, two static-text nodes, and three same-row buttons can be classified as the remote-debugging consent dialog even when no remote-debugging semantic anchor is present. remote_debugging_sheet_present then treats that geometry alone as proof and exact_allow_button presses the inferred outer button. That can act on an unrelated three-button Chromium sheet.

The inferred allow polarity is also inconsistent with the Windows implementation and is justified only by synthetic coordinates. Please bind the fallback to a Chromium-specific native consent identity that survives localization, prove the actual Allow/Cancel polarity from live localized macOS AX trees (including RTL), and add negative fixtures for unrelated three-button sheets with the same layout. Run the release-signed existing-profile macOS harness at the final SHA; the current synthetic matcher tests and one manually observed structure are insufficient for an automatic consent press.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@f-trycua f-trycua f-trycua requested changes
@injaneity injaneity Awaiting requested review from injaneity injaneity will be requested when the pull request is marked ready for review injaneity is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enderzcx @f-trycua